[b/328440720] Adjust expected results when casting STRING to INTEGER#1
Open
tanclary wants to merge 1 commit intownob:masterfrom
Open
[b/328440720] Adjust expected results when casting STRING to INTEGER#1tanclary wants to merge 1 commit intownob:masterfrom
tanclary wants to merge 1 commit intownob:masterfrom
Conversation
As detailed in looker-open-source/calcite#45, we should cast STRINGs to FLOAT64 before casting them to INTEGERs to avoid errors with decimals. This means the whole part of the result is sometimes differs from the original string.
Anthrino
approved these changes
Mar 12, 2024
Anthrino
left a comment
Anthrino
left a comment
There was a problem hiding this comment.
LGTM, might be good to revert this once root cause is fixed.
Author
The root cause is just that BigQuery doesn't allow it, nothing on our end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As detailed in looker-open-source/calcite#45, we should cast STRINGs to FLOAT64 before casting them to INTEGERs to avoid errors with decimals. This means the whole part of the result is sometimes differs from the original string.